Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bound to Listen gem requirement #48622

Merged
merged 1 commit into from Jul 2, 2023

Commits on Jul 2, 2023

  1. Add lower bound to Listen gem requirement

    An issue was recently opened with the following error message:
    
    ```
    .../activesupport-7.0.6/lib/active_support/evented_file_update_checker.rb:120:in `start': undefined method `wait_for_state' for #<Listen::Listener ...>
    ```
    
    The issue is that the user was using Listen 3.0.8, however the
    `wait_for_state` method was [added][1] in Listen 3.3.0
    
    We can make the error message a little better by defining a lower bound
    on Listen 3.3.0 (like we do for other optional dependencies):
    
    ```
    .../bundler/rubygems_integration.rb:280:in `block (2 levels) in replace_gem': can't activate listen (~> 3.3), already activated listen-3.0.8. Make sure all dependencies are added to Gemfile. (Gem::LoadError)
    ```
    
    There is definitely still room for improvement here, but this should
    be much more helpful in figuring out that the issue is a bad Listen
    version and not a bug in Rails.
    
    [1]: guard/listen@12b4fc5
    skipkayhil committed Jul 2, 2023
    Copy the full SHA
    f311725 View commit details
    Browse the repository at this point in the history