Bump rubocop to 0.71 #36426

abhaynikam · 2019-06-06T05:45:36Z

Rubocop channel 0.71 -> codeclimate/codeclimate-rubocop#183

Shoud we update the gemfile as well with gem "rubocop", "~> 0.71.0", require: false?

yahonda · 2019-06-06T06:07:13Z

I think you will need to update Gemfile and .rubocop.yml file. I'm preparing a similar change at another repository https://github.com/rsim/oracle-enhanced/pull/1887/files

I rather prefer @koic or someone who is familiar with RuboCop makes this kind of change.

abhaynikam · 2019-06-06T06:16:40Z

@yahonda Alright. @koic or someone who is familiar can pick this up. I'll just try one push and close the PR since I spent sometime on it 😄 . Hope that is fine.

yahonda · 2019-06-06T06:40:18Z

Great. I hope your next one should be fine.

abhaynikam · 2019-06-06T07:12:31Z

@yahonda : Everything passed here. Ping me if I should close this PR.

kamipo · 2019-06-06T07:37:22Z

actionview/test/actionpack/abstract/layouts_test.rb

@@ -295,7 +295,7 @@ class TestBase < ActiveSupport::TestCase
        10.times do |x|
          controller = WithString.new
          controller.define_singleton_method :index do
-            render template: ActionView::Template::Text.new("Hello string!"), locals: { :"x#{x}" => :omg }
+            render template: ActionView::Template::Text.new("Hello string!"), locals: { "x#{x}" => :omg }


Which cop does this violate?

Layout/EmptyLinesAroundBlockBody -> https://github.com/rails/rails/blob/master/.rubocop.yml#L65

This was changed in rubocop/rubocop#7090 I think

I asked why rubocop correct intentional symbol key to string key wrongly.

@kamipo : My bad. I wanted to comment it for another comment of your(#36426 (comment)).

Style/HashSyntax cop fails here. It should be following as per -> rubocop/rubocop#6948

Rubocop new syntax when keys are interpolated.

"x#{x}": :omg

I'll make that change.

This difference is due to the following changes.
rubocop/rubocop#6948

kamipo · 2019-06-06T07:38:01Z

activerecord/test/cases/associations/eager_test.rb

@@ -786,19 +786,17 @@ def test_eager_with_has_many_and_limit_and_conditions_on_the_eagers
  def test_eager_with_has_many_and_limit_and_scoped_conditions_on_the_eagers
    posts = nil
    Post.includes(:comments)
-      .where("comments.body like 'Normal%' OR comments.#{QUOTED_TYPE}= 'SpecialComment'")


#36426 (comment)

Don't apply your indentation edit.

% be rubocop -a activerecord/test/cases/associations/eager_test.rb Inspecting 1 file C Offenses: activerecord/test/cases/associations/eager_test.rb:792:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. activerecord/test/cases/associations/eager_test.rb:801:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. 1 file inspected, 2 offenses detected, 2 offenses corrected % git diff activerecord/test/cases/associations/eager_test.rb diff --git a/activerecord/test/cases/associations/eager_test.rb b/activerecord/test/cases/associations/eager_test.rb index f7aad9d775..42af1ac8d8 100644 --- a/activerecord/test/cases/associations/eager_test.rb +++ b/activerecord/test/cases/associations/eager_test.rb @@ -789,7 +789,6 @@ def test_eager_with_has_many_and_limit_and_scoped_conditions_on_the_eagers .where("comments.body like 'Normal%' OR comments.#{QUOTED_TYPE}= 'SpecialComment'") .references(:comments) .scoping do - posts = authors(:david).posts.limit(2).to_a assert_equal 2, posts.size end @@ -798,7 +797,6 @@ def test_eager_with_has_many_and_limit_and_scoped_conditions_on_the_eagers .where("authors.name = 'David' AND (comments.body like 'Normal%' OR comments.#{QUOTED_TYPE}= 'SpecialComment')") .references(:authors, :comments) .scoping do - count = Post.limit(2).count assert_equal count, posts.size end

kamipo · 2019-06-06T07:38:10Z

actionpack/test/dispatch/request_test.rb

@@ -680,8 +680,7 @@ class RequestProtocol < BaseRequestTest

 class RequestMethod < BaseRequestTest
  test "method returns environment's request method when it has not been
-    overridden by middleware".squish do


% be rubocop -a actionpack/test/dispatch/request_test.rb Inspecting 1 file C Offenses: actionpack/test/dispatch/request_test.rb:684:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. 1 file inspected, 1 offense detected, 1 offense corrected % git diff actionpack/test/dispatch/request_test.rb diff --git a/actionpack/test/dispatch/request_test.rb b/actionpack/test/dispatch/request_test.rb index eb49396145..0ec8dd25e0 100644 --- a/actionpack/test/dispatch/request_test.rb +++ b/actionpack/test/dispatch/request_test.rb @@ -681,7 +681,6 @@ class RequestProtocol < BaseRequestTest class RequestMethod < BaseRequestTest test "method returns environment's request method when it has not been overridden by middleware".squish do - ActionDispatch::Request::HTTP_METHODS.each do |method| request = stub_request("REQUEST_METHOD" => method)

koic · 2019-06-06T08:13:23Z

.rubocop.yml

@@ -77,7 +79,7 @@ Layout/EmptyLinesAroundMethodBody:
 Layout/EmptyLinesAroundModuleBody:
  Enabled: true

-Layout/FirstParameterIndentation:
+Layout/IndentFirstArgument:


I think it is preferable to move in ASCII order.

koic · 2019-06-06T08:13:44Z

Gemfile

@@ -28,8 +28,9 @@ gem "uglifier", ">= 1.3.0", require: false
 # Explicitly avoid 1.x that doesn't support Ruby 2.4+
 gem "json", ">= 2.0.0"

-gem "rubocop", ">= 0.47", require: false
+gem "rubocop", "~> 0.71.0", require: false


rails/rails repository is maintained by Gemfile.lock. Is this change meaningful?

koic · 2019-06-06T08:14:54Z

I think that Rails: Enabled: true can be removed from .rubocop.yaml.

diff --git a/.rubocop.yml b/.rubocop.yml
index 18c20776c6..22161b1e16 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -20,9 +20,6 @@ Performance:
   Exclude:
     - '**/test/**/*'

-Rails:
-  Enabled: true
-
 # Prefer assert_not over assert !
 Rails/AssertNot:
   Include:

It is enabled when require: rubocop-rails is specified in .rubocop.yml.
https://github.com/rubocop-hq/rubocop/pull/7093/files#diff-68891125561f1767ea375a89b05f7e1e

abhaynikam · 2019-06-06T10:21:57Z

@kamipo : Done with requested changes.

abhaynikam force-pushed the bump-codeclimate-rubocop-version branch from d2db3e5 to 1e7610e Compare June 6, 2019 06:57

rails-bot bot added actionpack actionview activerecord labels Jun 6, 2019

kamipo reviewed Jun 6, 2019

View reviewed changes

koic reviewed Jun 6, 2019

View reviewed changes

abhaynikam force-pushed the bump-codeclimate-rubocop-version branch 2 times, most recently from 3420cf8 to fa24346 Compare June 6, 2019 09:47

Bump rubocop to 0.71

00b3b68

abhaynikam force-pushed the bump-codeclimate-rubocop-version branch from fa24346 to 00b3b68 Compare June 6, 2019 10:05

kamipo merged commit 6481446 into rails:master Jun 6, 2019

This was referenced Jun 7, 2019

Bump RuboCop version to 0.71 rsim/oracle-enhanced#1887

Merged

Update for Layout/FirstParameterIndentation name change toshimaru/rubocop-rails_config#43

Merged

eugeneius mentioned this pull request Mar 27, 2020

Simplify GitHub Action RuboCop by using globally installed gems #38834

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rubocop to 0.71 #36426

Bump rubocop to 0.71 #36426

abhaynikam commented Jun 6, 2019

yahonda commented Jun 6, 2019

abhaynikam commented Jun 6, 2019

yahonda commented Jun 6, 2019

abhaynikam commented Jun 6, 2019

kamipo Jun 6, 2019

abhaynikam Jun 6, 2019

kamipo Jun 6, 2019

abhaynikam Jun 6, 2019

koic Jun 6, 2019

kamipo Jun 6, 2019

abhaynikam Jun 6, 2019

kamipo Jun 6, 2019

kamipo Jun 6, 2019

kamipo Jun 6, 2019

koic Jun 6, 2019

koic Jun 6, 2019

koic commented Jun 6, 2019

abhaynikam commented Jun 6, 2019

Bump rubocop to 0.71 #36426

Bump rubocop to 0.71 #36426

Conversation

abhaynikam commented Jun 6, 2019

yahonda commented Jun 6, 2019

abhaynikam commented Jun 6, 2019

yahonda commented Jun 6, 2019

abhaynikam commented Jun 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koic commented Jun 6, 2019

abhaynikam commented Jun 6, 2019