Simplify GitHub Action RuboCop by using globally installed gems #38834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
force-pushed
the
simpler-workflow-rubocop
branch
from
e73f1b6
to
c1e7268
Compare
olleolleolle
changed the title
|
We're now installing the latest version of RuboCop rather than the one in Gemfile.lock. This means that when a new RuboCop version is published, the check may start to fail if any rules that we have enabled have changed their behaviour. Currently those changes can be dealt with as part of a PR bumping the version in Gemfile.lock (e.g. #37821, #36426). What if we add a |
|
@eugeneius good point, worth a shot 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Install and run
rubocopas a global gem to speed up and simplify the linting workflow.Other Information