-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump RuboCop version to 0.71 #1887
Conversation
f98320f
to
e1b83c8
Compare
@koic I'm requesting your review because it gets these warnings. These warnings can be addressed by removing $ bundle exec rubocop
... snip ...
.rubocop.yml:1: `require` is concealed by line 2
Warning: unrecognized cop Performance/FlatMap found in .rubocop.yml
Warning: unrecognized cop Performance/RedundantMerge found in .rubocop.yml
Warning: unrecognized cop Performance/StartWith found in .rubocop.yml
Warning: unrecognized cop Performance/EndWith found in .rubocop.yml
Warning: unrecognized cop Performance/RegexpMatch found in .rubocop.yml
Warning: unrecognized cop Performance/ReverseEach found in .rubocop.yml
Warning: unrecognized cop Performance/UnfreezeString found in .rubocop.yml
Inspecting 66 files
..................................................................
66 files inspected, no offenses detected
$ Maybe I am misunderstanding this message Rails cops will be removed from RuboCop 0.72. Use the Put this in your gem 'rubocop-rails' And then execute: $ bundle install Put this into your require: rubocop-rails More information: https://github.com/rubocop-hq/rubocop-rails |
@koic Nevermind for my previous question, already answered by this pull request. |
.rubocop.yml
Outdated
@@ -54,7 +56,7 @@ Layout/EmptyLinesAroundMethodBody: | |||
Layout/EmptyLinesAroundModuleBody: | |||
Enabled: true | |||
|
|||
Layout/FirstParameterIndentation: | |||
Layout/IndentFirstArgument: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is preferable to move in ASCII order.
Ref: https://github.com/rails/rails/pull/36426/files#r291066852
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
https://github.com/rubocop-hq/rubocop/releases/tag/v0.71.0 Additional changes made: * Install `rubocop-rails` gem because Rails cops will be removed from RuboCop 0.72 * Rename `Layout/FirstParameterIndentation` to `Layout/IndentFirstArgument` to support RuboCop 0.68.0 ```ruby $ bundle exec rubocop Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`. (obsolete configuration found in .rubocop.yml, please update it) $ ``` * Use `rubocop-0-71` channel at Code Climate Refer https://github.com/codeclimate/codeclimate/releases/tag/v0.85.3
rails/rails#36426 has been merged. Thanks! |
This pull request bump sRuboCop version to 0.71
https://github.com/rubocop-hq/rubocop/releases/tag/v0.71.0
Additional changes made:
Install
rubocop-rails
gem because Rails cops will be removed from RuboCop 0.72Rename
Layout/FirstParameterIndentation
toLayout/IndentFirstArgument
to support RuboCop 0.68.0rubocop-0-71
channel at Code ClimateRefer https://github.com/codeclimate/codeclimate/releases/tag/v0.85.3