Extract join values to merge as an original type #16635
Closed
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```ActiveRecord::QueryMethods#joins!``` receives arguments as variable length arguments. So that it saves join values as Array. This affects ```ActiveRecord::Relation::Merger#merge_joins``` which handles joins by its type. If String joins merged twice, the second merge process raises ```ActiveRecord::ConfigurationError```
|
@cristianbica oops, thanks. I got it. |
|
@thedarkone thanks, I close this Pull Request. |
thedarkone
added a commit
to thedarkone/rails
that referenced
this pull request
Sep 12, 2014
JOIN clauses order is important, previous implementation always put string or arel joins at then end (after auto-generated association joins). Fixes rails#12953, rails#15488, rails#16635.
thedarkone
pushed a commit
to thedarkone/rails
that referenced
this pull request
Sep 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecord::QueryMethods#joins!receives arguments as variablelength arguments. So that it saves join values as Array.
This affects
ActiveRecord::Relation::Merger#merge_joinswhichhandles joins by its type. If String joins merged twice, the second
merge process raises
ActiveRecord::ConfigurationError