Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract join values to merge as an original type #16635

Closed
wants to merge 2 commits into from
Closed

Extract join values to merge as an original type #16635

wants to merge 2 commits into from

Commits on Aug 22, 2014

  1. Extract join values to merge as an original type 

    ```ActiveRecord::QueryMethods#joins!``` receives arguments as variable
length arguments. So that it saves join values as Array.

This affects ```ActiveRecord::Relation::Merger#merge_joins``` which
handles joins by its type. If String joins merged twice, the second
merge process raises ```ActiveRecord::ConfigurationError```
    Takamichi Yoshikawa committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    3aad7c5 View commit details
    Browse the repository at this point in the history

  2. Fix a broken markdown layout

    @adorechic
    adorechic committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    15a63b7 View commit details
    Browse the repository at this point in the history