Preserve user supplied JOIN order #15461
Conversation
|
Can we do this without adding a new possibly initialized instance variable? I don't want to keep new state in the |
@tenderlove thanks, done, re-pushed. The new version now also contains fix for #15488 ( |
|
Anything that can be done to help get this merged? I can confirm this fixes #15488 |
JOIN clauses order is important, previous implementation always put string or arel joins at then end (after auto-generated association joins). Fixes rails#12953, rails#15488, rails#16635.
thedarkone
force-pushed
the
join-order-fix
branch
from
1657c5e
to
bb322f3
Compare
|
Did some code tweaks and added Takamichi Yoshikawa's test case. @SebastianZaha @adorechic: sorry, that this taking so long to get merged in.. 😣 |
| join_dependency_param = {associations_name => subtree} | ||
| end | ||
| end | ||
| join_dependency_param |
There was a problem hiding this comment.
Having a hard time following these assignments. Can be nil, a hash, or a string… tough to trace its behavior among its collaborating methods.
Attempting to grok this code by refactoring it as I go through it.
|
@thedarkone Is this PR still relevant, or can it be closed? |
|
The issue of maintaining user supplied JOIN order is still relevant, but the PR is quite stale (AFAIK the code that this targets got changed considerably). I can't work on this right now, so if needs be the PR can be closed by the maintainers. |
|
It is indeed outdated. I'll close the PR and link to the open issues in case someone wants to pick it up. Thanks |
JOIN clauses order is important, previous implementation has always put string or arel joins at the end (after auto-generated association joins).
Fixes #12953, #15488, #16635.
/cc @tenderlove