Remove workaround for testing knative environment #30743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can now be done because fabric8io/kubernetes-client#4447 is included in version 6.3 of the k8s client
|
cc @manusa |
|
👍 I'll rebase #30480 once you merge this since I might include changes that affect this class and the KubernetesBuildItem in general. |
|
Cool |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gsmet
approved these changes
Jan 31, 2023
|
Note that this method will need refactoring when bumping the client to 6.5 or at most 6.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can now be done because
fabric8io/kubernetes-client#4447 is included in version 6.3 of the k8s client