Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SupportTestingClient interface #4659

Open
manusa opened this issue Dec 12, 2022 · 3 comments
Open

Remove SupportTestingClient interface #4659

manusa opened this issue Dec 12, 2022 · 3 comments
Assignees
Milestone

Comments

@manusa
Copy link
Member

manusa commented Dec 12, 2022

Removal of SupportTestingClient interface

@manusa in the last meeting we talked about whether it would make more sense here just to go ahead and remove the deprecated isAdaptable and all of these checks from the extensions. Would you rather that be a follow-on task instead?

Originally posted by @shawkins in #4631 (comment)

@shawkins
Copy link
Contributor

shawkins commented Dec 13, 2022

  • Step 1 - remove isAdaptable and SupportTestingClient from the extension impls.
  • Step 2 - consider deprecating SupportTestingClient / isSupported - if we don't think this style of support testing makes sense moving forward. It was brought up that for even the OpenShiftClient it's kind of dubious. fix #4659: deprecating support testing client #4869
  • Step 3 - later remove SupportTestingClient.

@shawkins shawkins added this to the 6.5.0 milestone Feb 9, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 11, 2023
also adding a generic supports method
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 11, 2023
also adding a generic supports method
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 20, 2023
also adding a generic supports method
@manusa manusa modified the milestones: 6.5.0, 6.6.0 Feb 20, 2023
@manusa manusa closed this as completed in 271abd9 Feb 20, 2023
@manusa manusa reopened this Mar 14, 2023
@manusa manusa modified the milestones: 6.6.0, 6.7.0 May 2, 2023
@manusa manusa modified the milestones: 6.7.0, 6.8.0 May 31, 2023
@manusa manusa modified the milestones: 6.8.0, 6.9.0 Jul 21, 2023
@manusa manusa modified the milestones: 6.9.0, 6.10.0 Oct 5, 2023
Copy link

stale bot commented Jan 3, 2024

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jan 3, 2024
@manusa manusa modified the milestones: 6.10.0, 6.11.0 Jan 10, 2024
@manusa manusa modified the milestones: 6.11.0, 7.x Feb 21, 2024
@manusa manusa removed this from the 7.x milestone Mar 7, 2024
@manusa manusa added this to the 7.0.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants