Knative deployer uses hasApiGroup to check for Knative support #31833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Nuri <marc@marcnuri.com>
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sgitario
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31787
This PR reverts (the reverted changes of) #30743
The
isSupportedmethod and its interface (SupportTestingClient) are deprecated and will be removed (fabric8io/kubernetes-client#4659).The recommended approach is to use
Client#supports(Class)orClient#supports(String, String). However, Knative has many resources (+versions) and its unclear which types/classes should be used for the check. So in this case, usinghasApiGroupwith the lenient matcher seems like reasonable choice to be able to target multiple Knative versions and APIs (Functions, Serving, Eventing, and so on).