replace atomicwrites with os.replace #10115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
force-pushed
the
atomicwrites-windows
branch
from
e3a0670
to
842e2dd
Compare
nicoddemus
reviewed
Jul 8, 2022
changelog/10114.improvement.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Replace `atomicwrites` dependency on windows with `os.replace`. | |||
There was a problem hiding this comment.
Suggested change
| Replace `atomicwrites` dependency on windows with `os.replace`. | |
| Replace `atomicwrites <https://github.com/untitaker/python-atomicwrites>`__ dependency on windows with `os.replace`. |
There was a problem hiding this comment.
Also perhaps we can consider this trivial and backport it to 7.1.x?
There was a problem hiding this comment.
yep will rename the file and amend when I'm at a computer
asottile
force-pushed
the
atomicwrites-windows
branch
from
842e2dd
to
4cd0322
Compare
asottile
added
the
needs backport
asottile
added
backport 7.1.x
and removed
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10114
diff is best viewed with ?w=1