Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$100 bounty] Remove atomicwrites package #30765

Closed
adeebshihadeh opened this issue Dec 17, 2023 · 0 comments · Fixed by #30769
Closed

[$100 bounty] Remove atomicwrites package #30765

adeebshihadeh opened this issue Dec 17, 2023 · 0 comments · Fixed by #30769
Labels
bounty good first issue Feasible for new contributers refactor

Comments

@adeebshihadeh
Copy link
Contributor

atomicwrites is deprecated and replaced by updates to the os module in Python 3.
See how pytest did the migration: pytest-dev/pytest#10115.

Two simple steps:

  • replace the few usages in common/file_helpers.py
  • remove it as a dependency from pyproject.toml
@adeebshihadeh adeebshihadeh added refactor good first issue Feasible for new contributers bounty labels Dec 17, 2023
@adeebshihadeh adeebshihadeh changed the title [$100 bounty] Remove atomicwr [$100 bounty] Remove atomicwrites package Dec 17, 2023
@royjr royjr mentioned this issue Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty good first issue Feasible for new contributers refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dependency: remove atomicwrites package royjr/openpilot
1 participant
@adeebshihadeh