Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using atomic writes #352

Closed
akhmerov opened this issue Jul 9, 2022 · 2 comments
Closed

Stop using atomic writes #352

akhmerov opened this issue Jul 9, 2022 · 2 comments

Comments

@akhmerov
Copy link
Contributor

akhmerov commented Jul 9, 2022

atomicwrites is now deprecated and recommends using os.replace instead. pytest used pytest-dev/pytest#10115 to make a replacement. While I don't expect that things would break on a short notice, we should consider stopping to rely on atomicwrites.
@basnijholt
Copy link
Member

Well caught. I'll fix this on a slow day.

@juandaanieel juandaanieel mentioned this issue Jul 18, 2022
Merged
@basnijholt
Copy link
Member

Fixed by #353 🎉

@basnijholt basnijholt mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhmerov @basnijholt