Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: attempt to simplify the multiply operator. #547
base: master
Are you sure you want to change the base?
Refactor: attempt to simplify the multiply operator. #547
Changes from 5 commits
b2b152a
63ba40b
e5091b7
96ec28a
895a526
91c30b4
c88822c
3908244
d7bec0b
5d23bec
0942ab4
999a778
b5e6217
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hurry on code review; but from re-inspecting this myself, I'm beginning to wonder about this
Opt
construction and the effect this could have on the parse output.In particular: perhaps it's better to have a chain of nested
Opt
nodes (recursive, instead of iterative as in this PR), because then matching an input against the parse tree can exit as soon as a single token doesn't match -- whereas theAnd[Opt(...), Opt(...), ...]
formulation here would be evaluated in full (I think?).