Refactor: attempt to simplify the multiply operator. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
commented
Mar 7, 2024
|
Not ignoring you, I have some work to catch up on tomorrow and over the weekend. |
jayaddison
commented
Mar 11, 2024
pyparsing/core.py
Outdated
| return ret | ||
| return And([self] * minElements) | ||
|
|
||
| return And([self] * minElements) + (Opt(self) * (maxElements - minElements)) |
There was a problem hiding this comment.
No hurry on code review; but from re-inspecting this myself, I'm beginning to wonder about this Opt construction and the effect this could have on the parse output.
In particular: perhaps it's better to have a chain of nested Opt nodes (recursive, instead of iterative as in this PR), because then matching an input against the parse tree can exit as soon as a single token doesn't match -- whereas the And[Opt(...), Opt(...), ...] formulation here would be evaluated in full (I think?).
…er of nodes in the optional-tail case
…red-vs-optional parse output nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ellipsisoperator (somewhat equivalent/similar toNonevalues -- translating to: unbound).cc @ptmcg