Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: attempt to simplify the multiply operator. #547

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Refactor: attempt to simplify the multiply operator. #547

wants to merge 13 commits into from

Commits on Mar 7, 2024

  1. Expand multiplication-by-ellipsis test coverage

    @jayaddison
    jayaddison committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b2b152a View commit details
    Browse the repository at this point in the history

  2. Refactor: attempt to simplify the multiply operator

    @jayaddison
    jayaddison committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    63ba40b View commit details
    Browse the repository at this point in the history

  3. Fixup: relocate the not-implemented type-guard condition

    @jayaddison
    jayaddison committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e5091b7 View commit details
    Browse the repository at this point in the history

  4. Fixup: relocate the not-implemented type-guard conditions (again)

    @jayaddison
    jayaddison committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    96ec28a View commit details
    Browse the repository at this point in the history

  5. Fixup: restore catch-all type-guard case to beginning of method

    @jayaddison
    jayaddison committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    895a526 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Refactor: restore recursively-generated nested-Opt tail nodes

    @jayaddison
    jayaddison committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    91c30b4 View commit details
    Browse the repository at this point in the history

  2. Refactor: brevity: allow a recursive call to emit an exact-match numb… 

    …er of nodes in the optional-tail case
    @jayaddison
    jayaddison committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c88822c View commit details
    Browse the repository at this point in the history

  3. Refactor: readability: prefer Empty() instead of And([])

    @jayaddison
    jayaddison committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3908244 View commit details
    Browse the repository at this point in the history

  4. Refactor: readability: use (redundant) parenthesis to demarcate requi… 

    …red-vs-optional parse output nodes
    @jayaddison
    jayaddison committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d7bec0b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Codestyle: fit exception message within reasonable line length limits

    @jayaddison
    jayaddison committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5d23bec View commit details
    Browse the repository at this point in the history

  2. Linting: resolve flake8 E721 (exact-type-comparison using equality op… 

    …erators)
    @jayaddison
    jayaddison committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0942ab4 View commit details
    Browse the repository at this point in the history

  3. Cleanup / safety: remove awkward elif-inlined type-validation logic.

    @jayaddison
    jayaddison committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    999a778 View commit details
    Browse the repository at this point in the history

  4. Typing: declare type-hints for minElements, maxElements vars.

    @jayaddison
    jayaddison committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b5e6217 View commit details
    Browse the repository at this point in the history