Remove shebang from nonexecutable script #7959
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrnciar
force-pushed
the
remove-shebang-from-nonexecutable-script
branch
from
a82b0c6
to
4905618
Compare
hrnciar
force-pushed
the
remove-shebang-from-nonexecutable-script
branch
2 times, most recently
from
28fa65d
to
54da45c
Compare
hroncok
reviewed
Apr 9, 2020
news/7959.removal
Outdated
| @@ -0,0 +1,17 @@ | |||
| Removes shebang from nonexecutable script. | |||
There was a problem hiding this comment.
I think removal is used for a functionality that has been deprecated and removed. A change like this doesn't actually remove / break anything, the shebang had no purpose. As such, I'd consider going with trivial.
https://pip.pypa.io/en/latest/development/contributing/#choosing-the-type-of-news-entry
When packaging pip in Fedora, we have realised that there is a nonexecutable file with a shebang line. It seems that the primary purpose of this file is to be imported from Python code and hence the shebang appears to be unnecessary. Shebangs are hard to handle when doing downstream packaging because it makes sense for upstream to use `#!/usr/bin/env python` while in the RPM package, we need to avoid that and use a more specific interpreter. Since the shebang was unused, I propose to remove it to avoid the problems. We have found more shebangs but in vendored packages. I have also opened PRs there: ActiveState/appdirs#144 psf/requests#5410 chardet/chardet#192 x
hrnciar
force-pushed
the
remove-shebang-from-nonexecutable-script
branch
from
54da45c
to
b438d47
Compare
pradyunsg
added
type: enhancement
pradyunsg
approved these changes
Apr 9, 2020
This was referenced Apr 26, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging pip in Fedora, we have realised
that there is a nonexecutable file with a shebang line.
It seems that the primary purpose of this file is to be imported from Python
code and hence the shebang appears to be unnecessary.
Shebangs are hard to handle when doing downstream packaging because it makes
sense for upstream to use
#!/usr/bin/env pythonwhile in the RPM package, weneed to avoid that and use a more specific interpreter. Since the shebang was
unused, I propose to remove it to avoid the problems.
We have found more shebangs but in vendored packages. I have also opened PRs there:
ActiveState/appdirs#144
psf/requests#5410
chardet/chardet#192