Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shebang from nonexecutable script #7959

Merged

Commits on Apr 9, 2020

  1. Remove shebang from nonexecutable script

    When packaging pip in Fedora, we have realised
    that there is a nonexecutable file with a shebang line.
    
    It seems that the primary purpose of this file is to be imported from Python
    code and hence the shebang appears to be unnecessary.
    
    Shebangs are hard to handle when doing downstream packaging because it makes
    sense for upstream to use `#!/usr/bin/env python` while in the RPM package, we
    need to avoid that and use a more specific interpreter. Since the shebang was
    unused, I propose to remove it to avoid the problems.
    
    We have found more shebangs but in vendored packages. I have also opened PRs there:
    ActiveState/appdirs#144
    psf/requests#5410
    chardet/chardet#192
    
    x
    hrnciar committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b438d47 View commit details
    Browse the repository at this point in the history