should the shebang of these files be removed?

[sandy-lcq]

Hi,

I noticed that some sources like below have shebang like "#!/usr/bin/env python"
src/pip/_internal/init.py
src/pip/_vendor/appdirs.py
src/pip/_vendor/chardet/cli/chardetect.py
src/pip/_vendor/requests/certs.py

I suspect "python: command not found" maybe reported on host which only support python3, and don't have python link to python3.

I have met similar problem on fedora31 docker image (not fedora31 desktop version, it has python link to python3) on other python packages. I don't know how to reproduce for pip, and I think maybe it also have this problem.

[deveshks]

The shebang present in src/pip/_internal/__init__.py has already been removed in #7959

The other listed files are from vendored dependencies, and hence have to be modified in their respected repo, and the vendored version update in pip to get rid of the shebang. More details about vendoring is present at Vendoring Policy

[sandy-lcq]

ok, thanks. I will report this to separated repo. and paste the related link here later.

[sandy-lcq]

psf/requests#5439
chardet/chardet#193
ActiveState/appdirs#145

[deveshks]

I think similar issues are already raised against these repos, as noted in #7959 (comment) . Could you check them if they are talking about the same files as in this ticket?

[sandy-lcq]

yes, thanks. I will close my issue.

[deveshks]

I think this issue can also be closed, since the changes are to be done in the vendored libraries (psf, chardet and appdirs) of pip, and there are already PRs opened to fix those in the respective repos.