fix: resolve navigation requests when request fails #9178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
fix-client-redirect
branch
2 times, most recently
from
0049f27
to
feb9aa9
Compare
OrKoN
force-pushed
the
fix-client-redirect
branch
from
feb9aa9
to
1dabf58
Compare
jrandolf
approved these changes
Oct 28, 2022
jrandolf
force-pushed
the
fix-client-redirect
branch
from
1dabf58
to
7c5bf0e
Compare
OrKoN
pushed a commit
that referenced
this pull request
Nov 2, 2022
🤖 I have created a release *beep* *boop*
---
<details><summary>puppeteer: 19.2.1</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* puppeteer-core bumped from 19.2.0 to ^19.2.1
</details>
<details><summary>puppeteer-core: 19.2.1</summary>
##
[19.2.1](puppeteer-core-v19.2.0...puppeteer-core-v19.2.1)
(2022-10-28)
### Bug Fixes
* resolve navigation requests when request fails
([#9178](#9178))
([c11297b](c11297b)),
closes [#9175](#9175)
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8768 fixes flakiness in handling navigations but it didn't account for the fact that subsequent navigation requests could be aborted via the request interception. In that case, the navigationResponseReceived promise would never be resolved. This PR adds a listener for the failed network requests and resolves the promise if the network request has failed. Adding test coverage for this seems tricky, as the reproduction depends on timing of the second navigation request.
Closes #9175