Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Investigation] Fix failing tests by timeout #47

Closed
wants to merge 5 commits into from

Conversation

aivus
Copy link
Member

@aivus aivus commented Aug 28, 2022

No description provided.

@aivus aivus marked this pull request as draft August 28, 2022 19:03
@aivus
Copy link
Member Author

aivus commented Aug 28, 2022

After the quick investigation is was found that this issue started to be happening after upgrading puppeteer package to version 16.1.1

And the errors are related to blockNavgation feature:

async function blockNavigation (page, url) {
logger.info(`block navigation for puppeteer page from url ${url}`);
page.on('request', req => {
if (req.isNavigationRequest() && req.frame() === page.mainFrame() && req.url() !== url) {
req.abort('aborted');
} else {
req.continue();
}
});
await page.setRequestInterception(true);
}

@aivus aivus changed the title Fix failing tests by timeout [Investigation] Fix failing tests by timeout Aug 28, 2022
@aivus aivus self-assigned this Sep 20, 2022
@aivus
Copy link
Member Author

aivus commented Nov 7, 2022

Fixed by puppeteer/puppeteer#9178
See puppeteer/puppeteer#9175

Dependency updated in #55

@aivus aivus closed this Nov 7, 2022
@aivus aivus deleted the fix-failing-tests branch November 7, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant