Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed .mjs proxies generation in conditions builds #567

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jul 3, 2023

No description provided.

@Andarist Andarist requested a review from emmatown July 3, 2023 13:51
@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2023

🦋 Changeset detected

Latest commit: 01d4a2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a096eaa) 92.11% compared to head (632c16e) 92.11%.

❗ Current head 632c16e differs from pull request most recent head 01d4a2e. Consider uploading reports for the commit 01d4a2e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          39       39           
  Lines        1952     1952           
  Branches      584      584           
=======================================
  Hits         1798     1798           
  Misses        144      144           
  Partials       10       10           
Impacted Files Coverage Δ
packages/cli/src/build/rollup.ts 94.44% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emmatown emmatown merged commit d4006c8 into main Jul 3, 2023
8 checks passed
@emmatown emmatown deleted the fix/mjs-proxies branch July 3, 2023 23:30
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants