Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra runtime checking tests for import conditions #569

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jul 4, 2023

follow up to #567

@Andarist Andarist requested a review from emmatown July 4, 2023 11:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

⚠️ No Changeset found

Latest commit: d37c91b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

resolve!(dir);
});

describe.each(["cjs", "mjs"] as const)("with %s", (moduleType) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually, I hate nested describe blocks a lot but I think it makes sense here when using .each

@Andarist Andarist force-pushed the add-runtime-tests-for-conditions branch from 1bca5dc to d37c91b Compare July 4, 2023 11:29
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (9132a5d) 92.11% compared to head (745fb92) 92.16%.

❗ Current head 745fb92 differs from pull request most recent head d37c91b. Consider uploading reports for the commit d37c91b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   92.11%   92.16%   +0.05%     
==========================================
  Files          39       39              
  Lines        1952     1952              
  Branches      584      571      -13     
==========================================
+ Hits         1798     1799       +1     
+ Misses        144      143       -1     
  Partials       10       10              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emmatown emmatown merged commit b7b883d into main Jul 5, 2023
8 checks passed
@emmatown emmatown deleted the add-runtime-tests-for-conditions branch July 5, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants