Fixed .mjs proxies generation in conditions builds (#567)

preconstruct · Jul 3, 2023 · d4006c8 · d4006c8
1 parent a096eaa
commit d4006c8
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/.changeset/clean-crabs-clean.md b/.changeset/clean-crabs-clean.md
@@ -0,0 +1,5 @@
+---
+"@preconstruct/cli": patch
+---
+
+Fixed `.mjs` proxies generation with `___experimentalFlags_WILL_CHANGE_IN_PATCH.importsConditions` and `exports.importConditionDefaultExport: 'default'`
diff --git a/packages/cli/src/build/__tests__/imports-conditions.ts b/packages/cli/src/build/__tests__/imports-conditions.ts
@@ -129,6 +129,11 @@ test("imports conditions", async () => {
 
     exports.something = something;
 
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-pkg.browser.cjs.mjs ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    export {
+      something
+    } from "./scope-pkg.browser.cjs.js";
+
     ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-pkg.browser.development.cjs.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
     'use strict';
 
@@ -147,6 +152,11 @@ test("imports conditions", async () => {
 
     exports.something = something;
 
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-pkg.browser.development.cjs.mjs ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    export {
+      something
+    } from "./scope-pkg.browser.development.cjs.js";
+
     ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-pkg.browser.development.esm.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
     function something() {
       console.log("a");
@@ -217,6 +227,11 @@ test("imports conditions", async () => {
 
     exports.something = something;
 
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-pkg.development.cjs.mjs ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    export {
+      something
+    } from "./scope-pkg.development.cjs.js";
+
     ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-pkg.development.esm.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
     function something() {
       console.log("a");

diff --git a/packages/cli/src/build/rollup.ts b/packages/cli/src/build/rollup.ts
@@ -149,7 +149,7 @@ export let getRollupConfig = (
       resolveErrorsPlugin(pkg, warnings, options.kind === "umd"),
       (options.kind === "node-prod" || isDefaultConditionsBuild) &&
         typescriptDeclarations(pkg),
-      (options.kind === "node-prod" || isDefaultConditionsBuild) &&
+      (options.kind === "node-prod" || options.kind === "conditions") &&
         pkg.exportsFieldConfig()?.importConditionDefaultExport === "default" &&
         mjsProxy(pkg),
       serverComponentsPlugin({ sourceMap: options.kind === "umd" }),