add qemu and buildx for multi arch (arm64) #4552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
hungran
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
hungran
commented
Aug 18, 2023
| @@ -54,6 +54,12 @@ jobs: | |||
| - name: Build web static | |||
| run: make build/web | |||
|
|
|||
| # Setup QEMU and Buildx. | |||
| - name: Set up QEMU | |||
| uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0 | |||
There was a problem hiding this comment.
Action QEMU v2.0.0 is using node16
docker/setup-qemu-action#48
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0 | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@dc7b9719a96d48369863986a06765841d7ea23f6 #2.0.0 |
hungran
commented
Aug 18, 2023
| @@ -54,6 +54,12 @@ jobs: | |||
| - name: Build web static | |||
| run: make build/web | |||
|
|
|||
| # Setup QEMU and Buildx. | |||
| - name: Set up QEMU | |||
| uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0 | |||
There was a problem hiding this comment.
Action QEMU v2.0.0 is using node16
docker/setup-qemu-action#48
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4552 +/- ##
==========================================
+ Coverage 29.91% 29.95% +0.03%
==========================================
Files 220 220
Lines 25873 25872 -1
==========================================
+ Hits 7741 7749 +8
+ Misses 17484 17476 -8
+ Partials 648 647 -1 ☔ View full report in Codecov by Sentry. |
|
Launcher included!!! |
kentakozuka
reviewed
Aug 23, 2023
| tags: ${{ env.GHCR }}/pipe-cd/pipecd:${{ env.PIPECD_VERSION }} | ||
|
|
| tags: | | ||
| ${{ env.GHCR }}/pipe-cd/piped:${{ env.PIPECD_VERSION }} | ||
| ${{ env.GCR }}/pipecd/piped:${{ env.PIPECD_VERSION }} | ||
|
|
|
@kentakozuka thanks for your feedback |
|
All xxx-okd are for the openshift on-premise environment, so maybe someone want that on arm64 nodes as well, so let's support that too 👍 |
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
|
@kentakozuka @khanhtc1202 |
tokku5552
pushed a commit
to tokku5552/pipecd
that referenced
this pull request
Aug 25, 2023
* add qemu and buildx for multi arch (arm64) Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add launcher multiple platform Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add okd, helloworld and pipectl arm64 Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp>
tokku5552
pushed a commit
to tokku5552/pipecd
that referenced
this pull request
Aug 25, 2023
* add qemu and buildx for multi arch (arm64) Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add launcher multiple platform Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add okd, helloworld and pipectl arm64 Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
* add qemu and buildx for multi arch (arm64) Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add launcher multiple platform Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add okd, helloworld and pipectl arm64 Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: ARM64 for piped and pipecd
I was tried from my local environment which using
docker buildxto build linux/arm64 for only Piped and PipeCD image, and quick setup with helm pipecd and piped seem oknot sure with
piped-okdandlauncherWhich issue(s) this PR fixes:
Fixes ##4544
Does this PR introduce a user-facing change?: N/A