Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support container images for the ARM64 architecture #4544

Closed
stormcat24 opened this issue Aug 14, 2023 · 3 comments
Closed

Support container images for the ARM64 architecture #4544

stormcat24 opened this issue Aug 14, 2023 · 3 comments
Labels
good first issue Good for newcomers kind/enhancement New feature or request

Comments

@stormcat24
Copy link
Contributor

What would you like to be added:

Build and release the container images for the ARM64 architecture.

Why is this needed:

I want to run PipeCD on ARM64-based Graviton2 to reduce AWS running costs. Many AWS users will welcome the release of container images for the ARM64 architecture.

What do you think?

@stormcat24 stormcat24 added the kind/enhancement New feature or request label Aug 14, 2023
@khanhtc1202 khanhtc1202 added the good first issue Good for newcomers label Aug 15, 2023
@hungran
Copy link
Contributor

hungran commented Aug 18, 2023

I'd like to work on this issue
correct me if i'm wrong
I was tried from my local environment which using docker buildx to build linux/arm64 for only Piped and PipeCD image, and quick setup with helm pipecd and piped seem ok
not sure with piped-okd and launcher

do you have any concern on that or with current situation, I believe just have platform linux/arm64 in github action docker build is enough?
maybe here?
https://github.com/hungran/pipecd/blob/master/.github/workflows/publish_image_chart.yaml#L77-L78

@hungran
Copy link
Contributor

hungran commented Aug 25, 2023

I believed this issue was solved by this
#4552

@kentakozuka
Copy link
Member

Solved by #4552.
Feel free to reopen if this is not yet fixed 👍
@hungran Big thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants