Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qemu and buildx for multi arch (arm64) #4552

Merged
merged 5 commits into from Aug 25, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/publish_image_chart.yaml
Expand Up @@ -54,6 +54,12 @@ jobs:
- name: Build web static
run: make build/web

# Setup QEMU and Buildx.
- name: Set up QEMU
uses: docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8 #v2.0.0
Copy link
Contributor Author

@hungran hungran Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action QEMU v2.0.0 is using node16
docker/setup-qemu-action#48

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@dc7b9719a96d48369863986a06765841d7ea23f6 #2.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above


# Login to push container images.
- name: Log in to GHCR
uses: docker/login-action@49ed152c8eca782a232dede0303416e8f356c37b #v2.0.0
Expand All @@ -76,16 +82,20 @@ jobs:
push: true
context: .
file: cmd/pipecd/Dockerfile
platforms: linux/amd64,linux/arm64
tags: ${{ env.GHCR }}/pipe-cd/pipecd:${{ env.PIPECD_VERSION }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove an empty line.

- name: Build and push piped image
uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
with:
push: true
context: .
file: cmd/piped/Dockerfile
platforms: linux/amd64,linux/arm64
tags: |
${{ env.GHCR }}/pipe-cd/piped:${{ env.PIPECD_VERSION }}
${{ env.GCR }}/pipecd/piped:${{ env.PIPECD_VERSION }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove an empty line.

- name: Build and push piped-okd image
uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
with:
Expand Down