Faster Scope->shouldInvalidateExpression() #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
fast-invalidate
branch
from
dd3b4b4
to
adb28dd
Compare
ondrejmirtes
requested changes
Dec 21, 2022
src/Analyser/MutatingScope.php
Outdated
| @@ -3500,6 +3500,11 @@ private function shouldInvalidateExpression(string $exprStringToInvalidate, Expr | |||
| return false; | |||
| } | |||
|
|
|||
| // Variables will not contain traversable expression. skip the NodeFinder overhead | |||
| if ($expr instanceof Variable) { | |||
There was a problem hiding this comment.
Only if the variable name is string
There was a problem hiding this comment.
good catch. fixed and re-measured. same characteristics.. seems most variables don't reference other variables :)
staabm
force-pushed
the
fast-invalidate
branch
from
adb28dd
to
e0cc637
Compare
|
Thank you! |
|
Thank you @staabm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when analyzing tcpdf.php most of the time is spend in FindFirst
blackfire run --ignore-exit-status php ../phpstan-src/bin/phpstan --debug -vvv analyze tcpdf.phpspeedup: