Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster Scope->shouldInvalidateExpression() #2139

Merged
merged 1 commit into from Dec 21, 2022
Merged

Faster Scope->shouldInvalidateExpression() #2139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Analyser/MutatingScope.php
View file
Open in desktop
Expand Up @@ -3500,6 +3500,11 @@ private function shouldInvalidateExpression(string $exprStringToInvalidate, Expr
return false;
}

// Variables will not contain traversable expressions. skip the NodeFinder overhead
if ($expr instanceof Variable && is_string($expr->name)) {
return $exprStringToInvalidate === $this->getNodeKey($expr);
}

$nodeFinder = new NodeFinder();
$expressionToInvalidateClass = get_class($exprToInvalidate);
$found = $nodeFinder->findFirst([$expr], function (Node $node) use ($expressionToInvalidateClass, $exprStringToInvalidate): bool {
Expand Down