Faster Scope->shouldInvalidateExpression()

phpstan · Dec 21, 2022 · dd3b4b4 · dd3b4b4
1 parent 7c68a12
commit dd3b4b4
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -3500,6 +3500,11 @@ private function shouldInvalidateExpression(string $exprStringToInvalidate, Expr
 			return false;
 		}
 
+		// Variables will not contain traversable expression. skip the NodeFinder overhead
+		if ($expr instanceof Variable) {
+			return $exprStringToInvalidate === $this->getNodeKey($expr);
+		}
+
 		$nodeFinder = new NodeFinder();
 		$expressionToInvalidateClass = get_class($exprToInvalidate);
 		$found = $nodeFinder->findFirst([$expr], function (Node $node) use ($expressionToInvalidateClass, $exprStringToInvalidate): bool {