You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue serves as an omnibus overview of the work being undertaken to improve Phoenix's ability to be hosted by web servers other than Cowboy, and as a follow-on benefit, simplifying the WebSocket implementation in Phoenix. The goals of this workup are to:
Allow Phoenix to provide WebSocket functionality via a Plug-mediated upgrade flow, using Plug's new Plug.Conn.upgrade_adapter/3
Expose sockets via the Sock API
Simplify the implementation of Phoenix.Endpoint by leveraging Plug.Router, now that everything is done via Plug
Remove the necessity for Phoenix.Endpoint.Cowboy2Handler, now that everything is done via Plug & Sock
The work to enable this spans a number of PRs across the Plug, Plug.Cowboy & Bandit repos:
All of the above work is complete, testing green, and functional (with the exception of commits to update Mix dependencies as the various PRs above are merged). The primary concern now is staging PR reviews in the correct order. To that end, a proposal:
Review & Merge Proposal
Plug folks to review & merge changes in Plug PR above and push a point release of Plug once merged
@mtrudel to update Plug.Cowboy & Bandit PRs to depend on this new released version
Plug.Cowboy folks to review & merge Plug.Cowboy PR above
This issue serves as an omnibus overview of the work being undertaken to improve Phoenix's ability to be hosted by web servers other than Cowboy, and as a follow-on benefit, simplifying the WebSocket implementation in Phoenix. The goals of this workup are to:
Plug.Conn.upgrade_adapter/3
Sock
APIPhoenix.Endpoint
by leveragingPlug.Router
, now that everything is done via PlugPhoenix.Endpoint.Cowboy2Handler
, now that everything is done via Plug & SockThe work to enable this spans a number of PRs across the Plug, Plug.Cowboy & Bandit repos:
Plug.Conn.upgrade_adapter/3
Sock
API to be drop-in compatible withPhoenix.Socket.Transport
All of the above work is complete, testing green, and functional (with the exception of commits to update Mix dependencies as the various PRs above are merged). The primary concern now is staging PR reviews in the correct order. To that end, a proposal:
Review & Merge Proposal
@moogle19 to review Bandit PR abovedoneThe text was updated successfully, but these errors were encountered: