Update Sock contract to mirror Phoenix.Socket.Transport #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at phoenixframework/phoenix#4973 and planned for in phoenixframework/phoenix#5003, this work updates the
Sock
API to mirrorPhoenix.Socket.Transport
, with a few additive changes:c:Sock.init/1
can now return the same set of tuples asc:Sock.handle_in/2
et al. This allowsinit
to send messages at connection timec:Sock.terminate/1
defines more possible arguments, codifying a number of common termination reasons such as server shutdown or timeout.{:push, ...}
or{:reply, ...}
may indicate the transmission of any type of framec:Phoenix.Socket.Transport.start_link/1
moves toc:Phoenix.Socket.start_link/1