Implement WebSocket support based on Plug.Conn.Adapter.upgrade/3 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moogle19 - would you be able to take a look at this in the context of phoenixframework/phoenix#5003? |
moogle19
reviewed
Oct 17, 2022
|
Thanks for the review @moogle19 ! |
mtrudel
force-pushed
the
sock_3_support
branch
2 times, most recently
from
2c6a646
to
57d6281
Compare
(tests pending once they get factored out of sock_test)
Co-authored-by: Kevin <moogle19@users.noreply.github.com>
mtrudel
force-pushed
the
sock_3_support
branch
from
57d6281
to
e56ed16
Compare
mtrudel
force-pushed
the
sock_3_support
branch
from
e56ed16
to
1ea1571
Compare
mtrudel
force-pushed
the
sock_3_support
branch
from
1ea1571
to
f3238be
Compare
mtrudel
force-pushed
the
sock_3_support
branch
from
f3238be
to
652836d
Compare
mtrudel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for upgrading HTTP connections to WebSocket connections by use of the
c:Plug.Conn.Adapter.upgrade/3callback. WebSocket implementations are called based on the Sock API (which mirrorsPhoenix.Socket.Transport) . This work is the Bandit analog of elixir-plug/plug#1119See phoenixframework/phoenix#5003 for an omnibus overview of the larger body of work that this PR is part of.