Implement no-op support for Plug.Conn.Adapter.upgrade/3 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work does not provide any concrete support for any protocols, it merely satisfies the plumbing requirements introduced in Plug by elixir-plug/plug#1119
See phoenixframework/phoenix#5003 for an omnibus overview.
Doing a no-op implementation here allows for the changes required in Plug to be isolated to a small set of PRs (namely this one and elixir-plug/plug_cowboy#88), while not breaking anything in the process.
Note that this PR is not entirely complete yet; it will need to have its dependency on Plug updated to a version which incorporates elixir-plug/plug#1119.