Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#30] Update FeatureRepository::remove contract to accept Feature instead of FeatureId #31

Merged
merged 1 commit into from Oct 7, 2021
Merged

[#30] Update FeatureRepository::remove contract to accept Feature instead of FeatureId #31

merged 1 commit into from Oct 7, 2021

Conversation

xserrat
Copy link
Contributor

@xserrat xserrat commented Oct 6, 2021

Closes #30

@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
@xserrat xserrat requested review from kpicaza and pcs289 October 6, 2021 21:39
@xserrat xserrat self-assigned this Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited

Codecov Report

Merging #31 (2716fd9) into 1.0.x (a8570c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              1.0.x      #31   +/-   ##
=========================================
  Coverage     95.89%   95.89%           
  Complexity       91       91           
=========================================
  Files            22       22           
  Lines           219      219           
=========================================
  Hits            210      210           
  Misses            9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8570c8...2716fd9. Read the comment docs.

kpicaza
kpicaza approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨🔨🔨 Nice job!!!

@kpicaza
Copy link
Member

kpicaza commented Oct 6, 2021 •
edited

This change will break the API, we will release it as 0.2.0, what do you think?

This was referenced Oct 6, 2021
Merged
Merged
@xserrat
Copy link
Contributor Author

xserrat commented Oct 7, 2021 •
edited

This change will break the API, we will release it as 0.2.0, what do you think?

Totally agree with you, we can merge everything and when we merged all dependant pull requests we can add the version 0.2.0 for toggle-core and then, update version and composer.json for dbal-toggle, inmemory-toggle and toggle-crud packages!

@xserrat xserrat merged commit 909814d into 1.0.x Oct 7, 2021
@xserrat xserrat deleted the issue#30-remove-contract branch October 7, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpicaza kpicaza kpicaza approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees

@xserrat xserrat

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update FeatureRepository::remove contract to accept Feature instead of FeatureId
2 participants
@xserrat @kpicaza