Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4] Update InMemoryFeatureRepository::remove contract with a Feature instead of FeatureId #5

Merged
merged 3 commits into from Oct 8, 2021

Conversation

xserrat
Copy link
Contributor

@xserrat xserrat commented Oct 6, 2021

@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
@xserrat xserrat requested review from kpicaza and pcs289 October 6, 2021 21:49
@xserrat xserrat self-assigned this Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #5 (f85a847) into 1.0.x (ffe3c26) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##               1.0.x        #5   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        20        20           
===========================================
  Files              5         5           
  Lines             62        62           
===========================================
  Hits              62        62           
Impacted Files Coverage Δ
src/InMemoryFeatureRepository.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe3c26...f85a847. Read the comment docs.

@xserrat xserrat merged commit 9f7459c into 1.0.x Oct 8, 2021
@xserrat xserrat deleted the issue#4-inmemory-repo branch October 8, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update InMemoryFeatureRepository::remove contract with a Feature instead of FeatureId
2 participants