Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4] Update DbalFeatureRepository::remove contract with a Feature instead of FeatureId #5

Merged
merged 3 commits into from Oct 8, 2021
Merged

[#4] Update DbalFeatureRepository::remove contract with a Feature instead of FeatureId #5

merged 3 commits into from Oct 8, 2021

Conversation

xserrat
Copy link
Contributor

@xserrat xserrat commented Oct 6, 2021 •
edited

Blocked by: pheature-flags/toggle-core#31
Closes #4

@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
@xserrat xserrat requested review from kpicaza and pcs289 October 6, 2021 21:54
@xserrat xserrat self-assigned this Oct 6, 2021
kpicaza
kpicaza approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨🔨🔨

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #5 (be4f090) into 1.0.x (6ce046a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              1.0.x       #5   +/-   ##
=========================================
  Coverage     54.92%   54.92%           
  Complexity       29       29           
=========================================
  Files             9        9           
  Lines           142      142           
=========================================
  Hits             78       78           
  Misses           64       64
Impacted Files Coverage Δ
src/Write/DbalFeatureRepository.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce046a...be4f090. Read the comment docs.

@xserrat xserrat merged commit 4f9afeb into 1.0.x Oct 8, 2021
@xserrat xserrat deleted the issue#4-dbal-remove branch October 8, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpicaza kpicaza kpicaza approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees

@xserrat xserrat

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DbalFeatureRepository::remove contract with a Feature instead of FeatureId
2 participants
@xserrat @kpicaza