Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: positional arguments in favor of keyword arguments #48735

Closed
wants to merge 17 commits into from
Closed

DEPR: positional arguments in favor of keyword arguments #48735

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
948eca4
Deprecate positional arguments in favor of keyword arguments
Sep 23, 2022
ca1d1d0
add entry to whatsnew
Sep 23, 2022
a4b0256
Fix: Review comments for deprecation PR
Sep 30, 2022
2acb431
Merge branch 'main' into deprecate_positional_arguments_groupby
ambujpawar Sep 30, 2022
e2602e0
Change whatsnew
Oct 8, 2022
469a9bc
Merge branch 'main' into deprecate_positional_arguments_groupby
Oct 8, 2022
ccfb976
Merge branch 'main' into deprecate_positional_arguments_groupby
ambujpawar Oct 11, 2022
4562ba6
Change value to ``value``
ambujpawar Oct 12, 2022
ac961d0
Move change from indexing to deprecations
Oct 16, 2022
33b9f15
Merge branch 'main' into deprecate_positional_arguments_groupby
Oct 16, 2022
87c525b
ADD: Deprecation warning
Oct 16, 2022
844e9cd
Merge branch 'main' into deprecate_positional_arguments_groupby
ambujpawar Oct 18, 2022
c39993c
use deprecation decorators instead of warning
Oct 26, 2022
8079969
Merge branch 'main' into deprecate_positional_arguments_groupby
Oct 26, 2022
ec1b703
fix: typo in import
Oct 26, 2022
c72091f
Merge branch 'main' into deprecate_positional_arguments_groupby
ambujpawar Oct 27, 2022
48d47f7
Merge branch 'main' into deprecate_positional_arguments_groupby
ambujpawar Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.6.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ Other API changes
Deprecations
~~~~~~~~~~~~
-
-

.. ---------------------------------------------------------------------------
.. _whatsnew_160.performance:
Expand Down Expand Up @@ -215,6 +214,7 @@ Indexing
- Bug in :meth:`DataFrame.reindex` filling with wrong values when indexing columns and index for ``uint`` dtypes (:issue:`48184`)
- Bug in :meth:`DataFrame.reindex` casting dtype to ``object`` when :class:`DataFrame` has single extension array column when re-indexing ``columns`` and ``index`` (:issue:`48190`)
- Bug in :func:`~DataFrame.describe` when formatting percentiles in the resulting index showed more decimals than needed (:issue:`46362`)
- :meth:`DataFrameGroupBy.fillna` and :meth:`SeriesGroupBy.fillna` now allow only keyword arguments to be passed except value(:issue:`48395`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after value, and please use value

Also please move to deprecations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I received contradicting review about moving/not moving to deprecations in the previous comments.

I am kinda confused now regarding which one should I actually do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a section Other Deprecations where we announce all deprecations before changing behavior in a later release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I could not find a section with the name Other Deprecations so moving it to deprecations for now.


Missing
^^^^^^^
Expand Down
2 changes: 2 additions & 0 deletions pandas/core/groupby/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,7 @@ def build_codes(lev_codes: np.ndarray) -> np.ndarray:
def fillna(
self,
value: object | ArrayLike | None = None,
*,
ambujpawar marked this conversation as resolved.
Show resolved Hide resolved
method: FillnaOptions | None = None,
axis: Axis | None = None,
inplace: bool = False,
Expand Down Expand Up @@ -2151,6 +2152,7 @@ def value_counts(
def fillna(
self,
value: Hashable | Mapping | Series | DataFrame = None,
*,
ambujpawar marked this conversation as resolved.
Show resolved Hide resolved
method: FillnaOptions | None = None,
axis: Axis | None = None,
inplace: bool = False,
Expand Down