Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getFixedT type-safe #1860

Merged
merged 1 commit into from Oct 27, 2022
Merged

Make getFixedT type-safe #1860

merged 1 commit into from Oct 27, 2022

Conversation

pedrodurek
Copy link
Member

Closes #1856

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.157% when pulling f46311d on pedrodurek:type-getFixedT into 96613fa on i18next:master.

@adrai adrai merged commit 6d3156a into i18next:master Oct 27, 2022
@adrai
Copy link
Member

adrai commented Oct 27, 2022

Do you want me to release a new patch version or should we wait?

@pedrodurek
Copy link
Member Author

@adrai I'll fix this one first, so we merge together

@adrai
Copy link
Member

adrai commented Oct 27, 2022

included in v22.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getFixedT keyPrefix with TS
3 participants