Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jszip from 2.6.1 to 3.7.0 #151

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2022

Bumps jszip from 2.6.1 to 3.7.0.

Changelog

Sourced from jszip's changelog.

v3.7.0 2021-07-23

  • Fix: Use a null prototype object for this.files (see #766)
    • This change might break existing code if it uses prototype methods on the .files property of a zip object, for example zip.files.toString(). This approach is taken to prevent files in the zip overriding object methods that would exist on a normal object.

v3.6.0 2021-02-09

  • Fix: redirect main to dist on browsers (see #742)
  • Fix duplicate require DataLengthProbe, utils (see #734)
  • Fix small error in read_zip.md (see #703)

v3.5.0 2020-05-31

  • Fix 'End of data reached' error when file extra field is invalid (see #544).
  • Typescript definitions: Add null to return types of functions that may return null (see #669).
  • Typescript definitions: Correct nodeStream's type (see #682)
  • Typescript definitions: Add string output type (see #666)

v3.4.0 2020-04-19

  • Add Typescript type definitions (see #601).

v3.3.0 2020-04-1

  • Change browser module resolution to support Angular packager (see #614).

v3.2.2 2019-07-04

  • No public changes, but a number of testing dependencies have been updated.
  • Tested browsers are now: Internet Explorer 11, Chrome (most recent) and Firefox (most recent). Other browsers (specifically Safari) are still supported however testing them on Saucelabs is broken and so they were removed from the test matrix.

v3.2.1 2019-03-22

  • Corrected built dist files

v3.2.0 2019-02-21

  • Update dependencies to reduce bundle size (see #532).
  • Fix deprecated Buffer constructor usage and add safeguards (see #506).

v3.1.5 2017-11-09

  • Fix IE11 memory leak (see #429).
  • Handle 2 nodejs deprecations (see #459).
  • Improve the "unsupported format" error message (see #461).
  • Improve webworker compatibility (see #468).
  • Fix nodejs 0.10 compatibility (see #480).
  • Improve the error without type in async() (see #481).

v3.1.4 2017-08-24

  • consistently use our own utils object for inheritance (see #395).
  • lower the memory consumption in generate* with a lot of files (see #449).

v3.1.3 2016-10-06

... (truncated)

Commits
  • e5b3f0d 3.7.0
  • e88ba4b Update for version 3.7.0
  • 9046487 Disable proto assert that fails in browsers
  • 6d029b4 Merge pull request #766 from MichaelAquilina/fix/files-null-prototype
  • bb38812 Ensure prototype isn't modified by zip file
  • d024c22 test: Add test case for loading zip filenames which shadow method names
  • 2235749 fix: Use a null prototype object for this.files
  • b7f472d Merge pull request #757: Update license to be valid spdx identifier
  • a311039 update license to be valid spdx identifier
  • 112fcdb 3.6.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 14, 2022
@jmac105
Copy link

jmac105 commented Mar 10, 2022

@optilude any chance of getting this merged in? There's a vulnerability in jszip@2.6.1 (https://nvd.nist.gov/vuln/detail/CVE-2021-23413).
If you need help getting this version tested etc please let us know we can raise an updated PR as required

@kant2002
Copy link
Collaborator

@jmac105 seems to be it's time to break backward compatibility. JSzip moves from sync implementation altogether, and I postpone update decision to update, hoping that one day I will come up with solution.

If you know specfic change which fix vulnerability, I prefer to temporary fork jszip, so existing user would not be affected by update

@kant2002
Copy link
Collaborator

If somebody know, is https://github.com/abbr/deasync would be a good choice as a stopgap solution to temporary provide sync interface?
Seems to be I found the fix is here Stuk/jszip#766

Bumps [jszip](https://github.com/Stuk/jszip) from 2.6.1 to 3.7.0.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/master/CHANGES.md)
- [Commits](Stuk/jszip@v2.6.1...v3.7.0)

---
updated-dependencies:
- dependency-name: jszip
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jszip-3.7.0 branch from dda0d0e to 8eceb13 Compare May 10, 2022 12:17
@kant2002
Copy link
Collaborator

I hope that Stuk/jszip#824 will fix the issue.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 8, 2022

Superseded by #170.

@dependabot dependabot bot closed this Sep 8, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/jszip-3.7.0 branch September 8, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants