Dependency updates. #532
Merged
Dependency updates. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace core-js with the much smaller set-immediate-shim. * Remove es6-promise as it is unused. * Update lie and readable-stream. The change from core-js to set-immediate-shim reduces the install size of jszip from 9.1MB to 2.2MB. The ponyfil for setImmediate is all that was used from core-js.
|
@chuyik the tests passed here (CI is enabled). Unfortunately for me a scoped fork cannot help me as |
Stuk
approved these changes
Feb 21, 2019
|
I'll publish this as version 3.2.0 in the morning PST. Unfortunately there's been some bitrot and the Saucelabs configurations are out of date, meaning I can't confirm that this works across all browsers. Looking at the change I think it should be ok. |
|
Done and done! |
|
Grate to see @Stuk working on jszip again 👍😃 |
|
Those files, downloaded from newest release 3.2.0 seem to contain
Are those updated or a mistake? |
|
Thanks for catching. I've published 3.2.1 with the correct dist files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from core-js to set-immediate-shim reduces the install size
of jszip from 9.1MB to 2.2MB. The ponyfil for setImmediate is all that
was used from core-js.