Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#296 - Replacing window references with self to allow running in a WebWorker #468

Merged
merged 3 commits into from Nov 5, 2017
Merged

#296 - Replacing window references with self to allow running in a WebWorker #468

merged 3 commits into from Nov 5, 2017

Conversation

Buslowicz
Copy link
Contributor

Fixing the issue preventing the use of jszip in a WebWorker.

Daniel Busłowicz and others added 3 commits October 15, 2017 14:40
@dduponchel
Copy link
Collaborator

I'm ok with the change (thank you!), I just pushed a new commit to remove the changes in the dist/ folder.
The build is now KO in nodejs 0.10 and 0.12, likely because of Medium/phantomjs/issues/753.
I'll merge this one and fix the build in an other pull request.

@dduponchel dduponchel merged commit 6aa06da into Stuk:master Nov 5, 2017
@dduponchel dduponchel mentioned this pull request Nov 9, 2017
Merged
jmerdich pushed a commit to jmerdich/jszip that referenced this pull request Jan 6, 2019
@jmerdich
Stuk#296 - Replacing window references with self to allow running…
b0279d6 
… in a WebWorker (Stuk#468)

* Stuk#296 - Replacing `window` references with `self` to allow running in a WebWorker

* Stuk#296 - Adding `self` to global objects for linter

* Revert the dist/ folder

These files are only generated on new releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Buslowicz @dduponchel