New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address s3 compatible remote state issues + logging #840
Conversation
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
I've converted this to draft whilst we still have items here in TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, just a couple nitpicks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good, I'll tentitively approve for now, please ping me again when the final TODO items are done and it's ready for review again. Nice work!
(question) Shall we also cover custom endpoint for STS and IAM as per the issue description:
For context, see the details: |
The https:// correction happens for all of the endpoints in the StringOk function. |
* S3/Dynamo hosts did not support configurations without proto:// (regression) * Invalid value for SuppressDebugLog in s3 backend config * No Logger passed to s3 backend config * Context needed to be tied to specific loggers to function * Add Head to state get, works around some compatability issues Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Works around issues in compatible services handing streaming checksums by pre-computing the hash and hitting the simpler code path. Hopefully this can be removed at some point, but for now it's a pretty big win. Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
This is not a requirement from aws-go-sdk, but it is for the hashicorp aws-go-sdk-base middleware. Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
1cbd353
to
46588eb
Compare
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
This PR started out addressing #821, but ended up being an investigation of the workflow itself instead of the not-adopted validation changes.
skip_s3_checksum
was added in https://github.com/opentofu/opentofu/pull/795/files to partially work around s3 compatible endpoints not supporting the default sha256 PARTIAL headers.[]byte
in memory, it's simple to compute the hash ahead of time and bypass the streaming PARTIAL header issue.TODO:
proto://
Resolves #821
Target Release
1.6.0
Draft CHANGELOG entry
BUG FIXES
proto://
now default tohttps://
instead of failing.