Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Client HeadObject requires SSE parameters #864

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

cam72cam
Copy link
Contributor

Matching GetObject, though we can't re-use the code since it's a distinct struct.

Broken in #840
Resolves #863

@Yantrio suggests that since this bug was not released in a stable release, it does not need to go in the CHANGELOG.md

Target Release

1.6.0

Matching GetObject, though we can't re-use the code since it's a
distinct struct.

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@cam72cam
Copy link
Contributor Author

TF_ACC=1 go test -coverprofile s3.cov ./internal/backend/remote-state/s3/...
ok      github.com/opentofu/opentofu/internal/backend/remote-state/s3   116.815s        coverage: 84.5% of statements

@cam72cam cam72cam merged commit 49f631d into main Nov 13, 2023
9 checks passed
@cam72cam cam72cam deleted the 863-broken_s3_remote_state_encryption branch November 13, 2023 18:16
thumperward pushed a commit to thumperward/opentf that referenced this pull request Jan 10, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypted S3 remote-state backend broken in Alpha4
3 participants