Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address s3 compatible remote state issues + logging #840

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Address s3 compatible remote state issues + logging #840

merged 11 commits into from
Nov 9, 2023

Commits on Nov 9, 2023

  1. Fix multiple s3 remote-state issues 

    * S3/Dynamo hosts did not support configurations without proto:// (regression)
* Invalid value for SuppressDebugLog in s3 backend config
* No Logger passed to s3 backend config
* Context needed to be tied to specific loggers to function
* Add Head to state get, works around some compatability issues

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1b97210 View commit details
    Browse the repository at this point in the history

  2. Fix putting state in s3 compatible services 

    Works around issues in compatible services handing streaming checksums
by pre-computing the hash and hitting the simpler code path.

Hopefully this can be removed at some point, but for now it's a pretty
big win.

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d41e8dd View commit details
    Browse the repository at this point in the history

  3. Add logging integration for s3 remote-state Delete() 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bb78831 View commit details
    Browse the repository at this point in the history

  4. Prefix non-proto endpoints with https:// 

    This is not a requirement from aws-go-sdk, but it is for the hashicorp
aws-go-sdk-base middleware.

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3fb97f6 View commit details
    Browse the repository at this point in the history

  5. Only compute the sha256 when needed (default) 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4a65aed View commit details
    Browse the repository at this point in the history

  6. Simplify PutObject sha256 computation 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    65d39f5 View commit details
    Browse the repository at this point in the history

  7. Add s3 backend function for attaching logging to context 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d19b88e View commit details
    Browse the repository at this point in the history

  8. Add tests for s3 backend endpoint manipulation 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0cf1cdb View commit details
    Browse the repository at this point in the history

  9. Revert to BaseEndpoint instead of EndpointResolver 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8af0aa1 View commit details
    Browse the repository at this point in the history

  10. Update changelog for #821 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7febd2e View commit details
    Browse the repository at this point in the history

  11. Remove comments for old endpoint resolver attempt 

    Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
    @cam72cam
    cam72cam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    46588eb View commit details
    Browse the repository at this point in the history