-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge all Prow CI scripts into one #839
Conversation
Overall approach looks sound, just need to clean up some of the duplicated code and correct things to use RHEL 8.6 |
bf40222
to
fa25711
Compare
a879002
to
ffaee4e
Compare
This is failing on:
|
I think the permissions problem is due to this:
The Maybe we hack around this by copying |
Regroup all CI scripts that build an RHCOS image and test it into a single one to avoid duplication. This will also simplify future CI changes.
Looks promising
|
Next step in openshift/release#29329 once this one is ready |
/lgtm Great job, @travier ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: miabbott, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@travier: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This will increase code re-use and simplify future CI changes.