-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify CI scripts to use RHEL 8.6 repos #838
Conversation
We've switched to using RHEL 8.6, so this workaround is no longer needed. This reverts commit 68ec9f3.
We've moved to using RHEL 8.6, so let's change CI accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea, but LGTM as is too.
# we want to use RHEL 8.5 for testing until we can start using 8.6 | ||
# see https://github.com/openshift/release/pull/26193 | ||
curl -L http://base-"${ocpver_mut}"-rhel85.ocp.svc.cluster.local > src/config/ocp.repo | ||
curl -L http://base-"${ocpver_mut}"-rhel86.ocp.svc.cluster.local > src/config/ocp.repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: we can parse the RHEL version from automatic-version-prefix
.
OK, this works:
rhelver=$(rpm-ostree compose tree --print-only manifest.yaml | jq -r '.["automatic-version-prefix"]' | cut -f2 -d.)
With #803, it becomes a variable in the manifest so it's even more accessible. But sadly rpm-ostree doesn't reserialize variables, so we'd have to parse the YAML directly. We could change that though.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merging this one as part of #839 |
/close Preferring #839 |
@miabbott: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@miabbott: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We've switched to using RHEL 8.6 in the manifest + downstream, so update the CI scripts accordingly.