Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2494: Bump node and yarn versions in docker builder file #7306

Merged
merged 1 commit into from Mar 18, 2021
Merged

CONSOLE-2494: Bump node and yarn versions in docker builder file #7306

merged 1 commit into from Mar 18, 2021

Conversation

zherman0
Copy link
Member

Need to wait for [ART-2456] to be complete and for PR7304 to merge.

This bumps dependencies for nodejs and yarn in the build file.

@zherman0 zherman0 changed the title Bump node and yarn versions CONSOLE-2494: Bump node and yarn versions in docker builder file Nov 24, 2020
@zherman0
Copy link
Member Author

/hold

Waiting for PR7304 to merge

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020
@spadgett
Copy link
Member

Need to wait for [ART-2456] to be complete and for PR7304 to merge.

This bumps dependencies for nodejs and yarn in the build file.

@zherman0 We should combine this with #7221 so we only update the builder image once. cc @suomiy

@spadgett spadgett mentioned this pull request Nov 24, 2020
Closed
@spadgett
Copy link
Member

Let's update kubectl as well.

@atiratree
Copy link
Member

@zherman0 We should combine this with #7221 so we only update the builder image once. cc @suomiy

+1 feel free to move the changes from #7221 to this PR

@spadgett
Copy link
Member

I don't think we need to wait for the ART change although #7304 is in the merge queue.

@spadgett
Copy link
Member

@suomiy I added your commit from #7221 to @zherman0's PR. I'm about to build and push the image to Quay.

@atiratree
Copy link
Member

@spadgett
great! Let me know once you have the image so I can rerun the tests in openshift/release#13715

@yselkowitz
Copy link
Contributor

Wouldn't the yarn tarball name in Dockerfile.product also need to be updated for this?

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

Wouldn't the yarn tarball name in Dockerfile.product also need to be updated for this?

Isn't that part of #7304? I don't think it needs to be in one PR. It shouldn't break anything if done separately.

@yselkowitz
Copy link
Contributor

#7304 doesn't touch yarn, only nodejs.

@yselkowitz
Copy link
Contributor

/retest

@atiratree
Copy link
Member

it seems that the new node/yarn may have broken the analyze script: openshift/release#13715

@atiratree atiratree mentioned this pull request Nov 30, 2020
Merged
@zherman0
Copy link
Member Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@zherman0
Copy link
Member Author

@spadgett - I think all the other dependencies for this update has been merged. Can we get an LGTM?

@spadgett
Copy link
Member

@suomiy Sorry, missed this. It looks like we're running into this problem? webpack/webpack#4629

@zherman0
Copy link
Member Author

/hold
Holding for the PR from openshift

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@atiratree
Copy link
Member

@suomiy Sorry, missed this. It looks like we're running into this problem? webpack/webpack#4629

@spadgett seems like this issue got fixed recently. Should we update webpack-cli to the newest version to proceed with this one?

@spadgett
Copy link
Member

spadgett commented Jan 6, 2021

@suomiy Sorry, missed this. It looks like we're running into this problem? webpack/webpack#4629

@spadgett seems like this issue got fixed recently. Should we update webpack-cli to the newest version to proceed with this one?

Sounds good to me. We're working on updating our dependencies anyway. Thanks!

@atiratree
Copy link
Member

@spadgett @zherman0 Is there an update on this one? I also saw the expect library has been removed from this PR, can you please elaborate on the reason?

@spadgett
Copy link
Member

@zherman0 It looks like you lost the changes from commit 18f12ad in the last push.

@vojtechszocs
Copy link
Contributor

@christianvogt @vojtechszocs FYI, this PR bumps node. We need to bump webpack-cli first, though.

@spadgett #8269 bumps webpack-cli to 4.5.0

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@vojtechszocs
Copy link
Contributor

/approve

1 similar comment
@glekner
Copy link
Contributor

glekner commented Mar 9, 2021

/approve

@glekner
Copy link
Contributor

glekner commented Mar 9, 2021

@bparees can you lgtm

@bparees
Copy link

bparees commented Mar 9, 2021

@bparees can you lgtm

i think that should come from @spadgett on this one.

/assign @spadgett

@vojtechszocs vojtechszocs mentioned this pull request Mar 11, 2021
Merged
spadgett
spadgett reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zherman0 I think we should go ahead and move to the latest kubectl as well, 1.20.4.

Dockerfile.builder Outdated Show resolved Hide resolved
@spadgett
Copy link
Member

@zherman0 Can you update the engines value in package.json and also update the README for the new node version?

@spadgett
Copy link
Member

openshift/release#13715 has merged

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@spadgett
Copy link
Member

I just built and pushed the latest image to quay: https://quay.io/repository/coreos/tectonic-console-builder?tab=tags

spadgett
spadgett approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, spadgett, vojtechszocs, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2021 •
edited

@zherman0: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 18f12ad link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@glekner
Copy link
Contributor

glekner commented Mar 18, 2021

/retest

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit b804fd9 into openshift:master Mar 18, 2021
@glekner glekner mentioned this pull request Mar 21, 2021
Merged
@spadgett spadgett added this to the v4.8 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yselkowitz yselkowitz yselkowitz left review comments

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@vojtechszocs vojtechszocs

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@zherman0 @spadgett @atiratree @yselkowitz @openshift-ci-robot @vojtechszocs @glekner @bparees @openshift-merge-robot