Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamic-plugin-sdk] Reducer - convert extensions from static to dynamic #7854

Merged
merged 1 commit into from May 1, 2021
Merged

[dynamic-plugin-sdk] Reducer - convert extensions from static to dynamic #7854

merged 1 commit into from May 1, 2021

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Jan 17, 2021 •
edited

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2021
@glekner glekner marked this pull request as draft January 17, 2021 14:40
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 17, 2021
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk labels Jan 17, 2021
@glekner
Copy link
Contributor Author

glekner commented Jan 17, 2021 •
edited

@vojtechszocs PTAL

getting this error
The previous state received by the reducer has unexpected type of "Function". Expected argument to be an object with the following keys: "cloudShell"

@glekner glekner force-pushed the dynamic-plugin-sdk-reducer branch 4 times, most recently from 619f50d to 62ee649 Compare January 18, 2021 12:38
@glekner glekner changed the title WIP | migrating reducer extension to new dynamic sdk [dynamic-plugin-sdk] Reducer - convert extensions from static to dynamic Jan 18, 2021
@glekner glekner marked this pull request as ready for review January 18, 2021 12:41
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2021
@glekner
Copy link
Contributor Author

glekner commented Jan 18, 2021

@christianvogt @vojtechszocs please review

@glekner glekner force-pushed the dynamic-plugin-sdk-reducer branch 4 times, most recently from 7036f09 to 5477625 Compare January 19, 2021 12:08
@glekner glekner marked this pull request as draft January 19, 2021 12:08
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2021
@glekner glekner force-pushed the dynamic-plugin-sdk-reducer branch 2 times, most recently from f4bca91 to c501016 Compare January 20, 2021 11:30
@spadgett
Copy link
Member

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/ceph-storage-plugin

In response to this:

/override ci/prow/ceph-storage-plugin

The ceph-storage-plugin job should only have run on PRs with changes to frontend/packages/ceph-storage-plugin. It failed due to an unrelated CI config change. Overriding status on this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/topology Related to topology label Feb 14, 2021
@glekner glekner marked this pull request as ready for review February 14, 2021 07:31
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@christianvogt
Copy link
Contributor

/hold
e2e is consistently failing, please investigate

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@glekner
Copy link
Contributor Author

glekner commented Apr 25, 2021

The failing test:

Visiting Overview page DaemonSets : displays a daemonset in the overview list page Error: Failed: unhandled promise rejection: Error: configmaps "v2v-vmware" not found

Ran on my local machine
STORAGE_CLASS=ocs-storagecluster-ceph-rbd NO_HEADLESS=true FAIL_FAST=false yarn run test-protractor-suite --params.openshift true --specs="integration-tests/tests/base.scenario.ts,integration-tests/tests/overview/overview.scenario.ts"

And it ss passing locally on my machine.
image

any thoughts @spadgett @jeff-phillips-18 @christianvogt ?

@glekner glekner force-pushed the dynamic-plugin-sdk-reducer branch 2 times, most recently from f189285 to 603107d Compare April 27, 2021 11:42
@glekner
Copy link
Contributor Author

glekner commented Apr 27, 2021

/retest

@glekner
Copy link
Contributor Author

glekner commented Apr 28, 2021

@vojtechszocs I applied your patch.

still fails on the same test


Visiting Overview page.DaemonSets: displays a daemonset in the overview list page expand_less | 3s
-- | --
Error: Failed: unhandled promise rejection: Error: configmaps "v2v-vmware" not found

pretty stuck here @christianvogt @vojtechszocs

@vojtechszocs
Copy link
Contributor

@glekner The KubeVirt Redux reducer extension should be gated by KubeVirt feature flag, just like it was gated in plugin.tsx file.

@glekner
Copy link
Contributor Author

glekner commented Apr 29, 2021

tests passing. please re-lgtm @spadgett @christianvogt

@vojtechszocs
Copy link
Contributor

/lgtm

@vojtechszocs
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, glekner, rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@glekner
Copy link
Contributor Author

glekner commented Apr 30, 2021

/retest

1 similar comment
@vojtechszocs
Copy link
Contributor

/retest

@spadgett
Copy link
Member

/skip

@glekner
Copy link
Contributor Author

glekner commented May 1, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2021 •
edited

@glekner: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/analyze f3c545a link /test analyze

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7650eae into openshift:master May 1, 2021
@spadgett spadgett added this to the v4.8 milestone May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs vojtechszocs requested changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@vojtechszocs vojtechszocs

@rawagner rawagner

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@glekner @spadgett @openshift-ci-robot @christianvogt @vojtechszocs @rawagner @openshift-bot @openshift-merge-robot