-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add expect library for kubevirt tests #7221
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: suomiy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@suomiy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bump: did a PR against openshift/release#13715 |
@@ -27,7 +27,7 @@ RUN chmod 777 -R ${HOME} | |||
|
|||
RUN apt-get update \ | |||
&& apt-get install --no-install-recommends -y -q \ | |||
curl wget git unzip bzip2 jq \ | |||
curl wget git unzip bzip2 jq expect \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should update node and probably kubectl at the same time so we don't have to replace the builder image twice. @zherman0 was looking at that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that means, once this PR is merged? #7280
should I update kubectl in this PR to some version? or is/will be there a special PR for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing in favor of #7306, which contains this commit. /close |
@spadgett: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett can you please review and update the tectonic-console-builder image?