Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expect library for kubevirt tests #7221

Closed
wants to merge 1 commit into from

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Nov 16, 2020

@spadgett can you please review and update the tectonic-console-builder image?

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suomiy
To complete the pull request process, please assign rhamilto after the PR has been reviewed.
You can assign the PR to them by writing /assign @rhamilto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

@suomiy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 3045474 link /test e2e-gcp-console
ci/prow/images 3045474 link /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atiratree
Copy link
Member Author

bump: did a PR against openshift/release#13715

@@ -27,7 +27,7 @@ RUN chmod 777 -R ${HOME}

RUN apt-get update \
&& apt-get install --no-install-recommends -y -q \
curl wget git unzip bzip2 jq \
curl wget git unzip bzip2 jq expect \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should update node and probably kubectl at the same time so we don't have to replace the builder image twice. @zherman0 was looking at that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that means, once this PR is merged? #7280

should I update kubectl in this PR to some version? or is/will be there a special PR for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @suomiy, I missed this question. Basically I think #7306 and this should be combined. That way we only need to update the builder image once since there are several steps.

@spadgett
Copy link
Member

Closing in favor of #7306, which contains this commit.

/close

@openshift-ci-robot
Copy link
Contributor

@spadgett: Closed this PR.

In response to this:

Closing in favor of #7306, which contains this commit.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants